Fix sitemap grid render incorrect base urls for multiple stores#18000
Fix sitemap grid render incorrect base urls for multiple stores#18000magento-engcom-team merged 1 commit intomagento:2.2-developfrom nntoan:2.2-develop
Conversation
|
Hi @nntoan. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
@magento-engcom-team give me test instance |
|
Hi @nntoan. Thank you for your request. I'm working on Magento instance for you |
|
Hi @nntoan, here is your new Magento instance. |
|
Hi @sidolov, thank you for the review. |
|
Hi @nntoan. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
In
Magento/Sitemap/Block/Adminhtml/Grid/Renderer/Link.php, we've created new instance for\Magento\Sitemap\Model\Sitemap. That lead to$sitemap->getStoreId()isNULLall the time, thesitemap.xmlgenerated still using correct store id because of we load$sitemapinstance from the collection which retrieve data directly from the database.So to fix this issue, we should set the store id for the current sitemap object based on store id retrieved from the current row.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist